[SPARK-54921][CORE] Add parentIds to StageData #53698
Open
+21,247
−19,780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-54921 === This comment was automatically generated by GitHub Actions |
warrenzhu25
changed the title
### What changes were proposed in this pull request? This PR adds a new `parentIds` field to the `StageData` model and its corresponding protobuf representation. Specific changes include: - Updated `store_types.proto` to include `repeated int64 parent_ids`. - Added `parentIds` to `v1.StageData` in `api.scala` as a defaulted parameter at the end of the constructor to maintain source compatibility. - Updated `LiveStage`, `AppStatusStore`, and `StageDataWrapperSerializer` to handle `parentIds`. - Added tests for `parentIds` in `KVStoreProtobufSerializerSuite`. ### Why are the changes needed? The `parentIds` field is necessary for tracking stage dependencies in the Spark UI and other status-related tools. ### Does this PR introduce _any_ user-facing change? No, this change updates internal models and the REST API but does not alter the primary user-facing UI or behavior. ### How was this patch tested? The changes were tested by running the `KVStoreProtobufSerializerSuite`: ``` build/sbt "core/testOnly org.apache.spark.status.protobuf.KVStoreProtobufSerializerSuite" ``` All 20 tests passed. ### Was this patch authored or co-authored using generative AI tooling? Yes, assisted by Gemini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a new
parentIdsfield to theStageDatamodel and its corresponding protobuf representation.Specific changes include:
store_types.prototo includerepeated int64 parent_ids.parentIdstov1.StageDatainapi.scalaas a defaulted parameter at the end of the constructor to maintain source compatibility.LiveStage,AppStatusStore, andStageDataWrapperSerializerto handleparentIds.parentIdsinKVStoreProtobufSerializerSuite.Why are the changes needed?
The
parentIdsfield is necessary for tracking stage dependencies in the Spark UI and other status-related tools.Does this PR introduce any user-facing change?
No, this change updates internal models and the REST API but does not alter the primary user-facing UI or behavior.
How was this patch tested?
The changes were tested by running the
KVStoreProtobufSerializerSuite:All 20 tests passed.
Was this patch authored or co-authored using generative AI tooling?
Yes, assisted by Gemini.