[SPARK-54954][PYTHON] Fix remote related type hints in util.py #53722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Sub-task SPARK-54954 === This comment was automatically generated by GitHub Actions |
HyukjinKwon
approved these changes
Jan 8, 2026
gaogaotiantian
changed the title
Contributor
Author
|
@HyukjinKwon , I updated this PR a bit because I realized that the original code mixed the concept of a |
Member
|
Merged to master. |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Jan 9, 2026
### What changes were proposed in this pull request?
* Add overload stubs for `remote_only`.
* Distinguish remote and normal SparkSession
* Do some type assertions so we don't need all the ignore comments
### Why are the changes needed?
When we do something like
```python
property
remote_only
def method(self):
...
```
The latest version of mypy is not happy because it believes `remote_only` can return a `property`. We can't do `property` on a `property`.
By adding the explicit overload, mypy knows that `remote_only` always return a callable when given a callable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Wait for CI.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor (claude-4.5-opus-high)
Closes apache#53722 from gaogaotiantian/fix-remote-only-overload.
Authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remote_only.Why are the changes needed?
When we do something like
The latest version of mypy is not happy because it believes
remote_onlycan return aproperty. We can't do@propertyon aproperty.By adding the explicit overload, mypy knows that
remote_onlyalways return a callable when given a callable.Does this PR introduce any user-facing change?
No
How was this patch tested?
Wait for CI.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor (claude-4.5-opus-high)