[SPARK-55790][Geo][SQL] Build a complete SRS registry using PROJ 9.7.1 data#54571
Open
uros-db wants to merge 3 commits intoapache:masterfrom
Open
[SPARK-55790][Geo][SQL] Build a complete SRS registry using PROJ 9.7.1 data#54571uros-db wants to merge 3 commits intoapache:masterfrom
uros-db wants to merge 3 commits intoapache:masterfrom
Conversation
uros-db
commented
Mar 2, 2026
Contributor
Author
uros-db
left a comment
There was a problem hiding this comment.
@szehon-ho @cloud-fan Please review.
uros-db
commented
Mar 2, 2026
Contributor
Author
uros-db
left a comment
There was a problem hiding this comment.
Docker integration failure seems unrelated to these changes.
szehon-ho
reviewed
Mar 2, 2026
Member
szehon-ho
left a comment
There was a problem hiding this comment.
- the pr has two generatedcsv which is very big. just wondering, is there no way to have one generated one, and copy it at build time?
- do we plan to run it just manually? I guess proj does not release that frequently that its worth to automate it?
Contributor
Author
There probably is a way, although I kind of like keeping these CSV files separate for JVM and Python. They are different modules, and geospatial types themselves live separately, so I think it would make sense to generate both in one go.
Yes, I think that we should be able to run this script manually and inspect the diff (e.g. new SRIDs) per version upgrade, and yes - PROJ releases aren't very frequent. We would otherwise need either CMake or SLQLite to fully automate this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Build a more complete Spatial Reference System (SRS) registry in Spark, introducing 10000+ entries sourced from the PROJ library's EPSG and ESRI databases, which will unlock substantially improving the breadth of geospatial type support.
Why are the changes needed?
This will enable Geometry and Geography types to support 10000+ additional SRID/CRS values, both in JVM and Python. Note that currently Geometry and Geography types offer only limited SRID support (a few hardcoded values).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The script and auto-generated golden files are self-contained.
Was this patch authored or co-authored using generative AI tooling?
Yes, Claude 4.6 Opus.