Skip to content

[SPARK-55802][SQL] Fix integer overflow when computing Arrow batch bytes #54584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 1 commit into from
+5 −5
Closed

[SPARK-55802][SQL] Fix integer overflow when computing Arrow batch bytes #54584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ class ArrowWriter(val root: VectorSchemaRoot, fields: Array[ArrowFieldWriter]) {
count += 1
}

def sizeInBytes(): Int = {
def sizeInBytes(): Long = {
var i = 0
var bytes = 0
var bytes = 0L
while (i < fields.size) {
bytes += fields(i).getSizeInBytes()
i += 1
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonArrowOutput.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ class SliceBytesArrowOutputProcessorImpl(
}
}

private def getBatchBytes(root: VectorSchemaRoot): Int = {
var batchBytes = 0
private def getBatchBytes(root: VectorSchemaRoot): Long = {
var batchBytes = 0L
root.getFieldVectors.asScala.foreach { vector =>
batchBytes += vector.getBufferSize
}
Expand Down
2 changes: 1 addition & 1 deletion ...scala/org/apache/spark/sql/execution/python/streaming/BaseStreamingArrowWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class BaseStreamingArrowWriterSuite extends SparkFunSuite {
()
}

when(arrowWriter.sizeInBytes()).thenAnswer { _ => sizeCounter }
when(arrowWriter.sizeInBytes()).thenAnswer { _ => sizeCounter.toLong }

// Set arrowMaxBytesPerBatch to 1
transformWithStateInPySparkWriter = new BaseStreamingArrowWriter(
Expand Down