feat: Floating Point Formatting for Scatter Point Chart #35915

alex241728 · 2025-10-30T17:26:24Z

SUMMARY

According to the issue #32902, the scatter point charts lack of generic axes, which means the scatter point charts only allow x-axis to be formatted with time formats. So, to fix the problem mentioned in this issue, our team adds a new floating-point formats for x-axis.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The before screenshot can be checked in issue #32902

The after screenshot:

TESTING INSTRUCTIONS

Create a scatter point chart or open an existing scatter point chart.
Select an "X-axis" in "Data" tab.
Check and select the format of "X-axis" in "Customize" tab. If the x-axis has a floating point data type (e.g. FLOAT, DOUBLE, REAL, NUMERIC, DECIMAL), the user interface will show "X Axis Number Format" and you can select formats for floating point numbers. If the x-axis has a time data type (e.g. TIMESTAMP WITHOUT TIME ZONE, TIMESTAMP WITH TIME ZONE), the user interface will show "Time Format" and you can select formats for time. The floating point formats are new features for x-axis, but the time formats are old features.

ADDITIONAL INFORMATION

Has associated issue: Fixes Scatter chart x-axis custom formatting option ignored with GENERIC_CHART_AXES enabled #32902
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Inefficient linear search in visibility function ▹ view
	Overly permissive numeric type detection ▹ view
	Duplicated Column Type Checking Logic ▹ view

Files scanned

File Path	Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx	✅
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx

bito-code-review · 2025-10-30T17:32:46Z

Interaction Diagram by Bito

sequenceDiagram
participant Dev as Developer
participant SharedCtrl as sharedControls.tsx<br/>🟩 Added | ●●● High
participant CtrlPanel as controlPanel.tsx<br/>🔄 Updated | ●●● High
participant Types as types.ts<br/>🔄 Updated | ●●○ Medium
participant Constants as constants.ts<br/>🔄 Updated | ●●○ Medium
participant TransformProps as transformProps.ts<br/>🔄 Updated | ●●● High
participant EchartsUI as EchartsTimeseries Component
Dev->>SharedCtrl: Define x_axis_number_format control
SharedCtrl-->>CtrlPanel: Export new control config
CtrlPanel->>CtrlPanel: Add visibility logic for numeric X-axis
CtrlPanel->>Types: Pass xAxisNumberFormat field
Types->>Constants: Initialize with SMART_NUMBER default
Constants->>TransformProps: Provide default format value
TransformProps->>TransformProps: Check if X-axis is Numeric type
TransformProps->>TransformProps: Apply getNumberFormatter(xAxisNumberFormat)
TransformProps-->>EchartsUI: Return formatted echartOptions

Critical path: Developer->sharedControls.tsx->controlPanel.tsx->transformProps.ts->EchartsTimeseries Component

Note: The diff adds support for numeric X-axis formatting in Timeseries charts. A new shared control 'x_axis_number_format' is defined, integrated into the control panel with conditional visibility for numeric columns, and used in transformProps to format numeric X-axis values alongside existing time-format support.

bito-code-review

Code Review Agent Run #2e97c7

Actionable Suggestions - 1

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx - 1
- Incorrect time format visibility for DATE columns · Line 127-127

Review Details

Files reviewed - 5 · Commit Range: 0fab5cb..f6a95e7
- superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx

sadpandajoe · 2025-10-30T18:12:14Z

@alex241728 thanks for creating the PR. Do you mind adding tests to your new feature?

rusackas · 2025-11-03T18:21:38Z

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install

A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

rusackas · 2025-11-05T00:49:12Z

Re-running CI 🤞

alex241728 · 2025-11-06T00:04:48Z

Re-running CI 🤞

I have completed the tests and rerun the precommit checks. I think the tests and checks are all passed. Can you check the pull request again. @rusackas

sadpandajoe · 2025-11-06T18:29:14Z

For tests, we should move away from it() and use test() as done in this PR: https://github.com/apache/superset/pull/35305/files

alex241728 · 2025-11-10T20:09:24Z

For tests, we should move away from it() and use test() as done in this PR: https://github.com/apache/superset/pull/35305/files

@sadpandajoe @rusackas The test format has been fixed.

Copilot

Pull Request Overview

This PR adds floating-point number formatting support for scatter chart x-axes, addressing the limitation where only time formatting was previously available. The implementation introduces a new xAxisNumberFormat control that appears when a numeric column (specifically floating-point types like FLOAT, DOUBLE, REAL, NUMERIC, DECIMAL) is selected for the x-axis.

Key Changes:

Added conditional number formatting for x-axis based on data type (numeric vs temporal)
Introduced new x_axis_number_format control with visibility logic tied to column data types
Default number format set to 'SMART_NUMBER' for numeric x-axes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`transformProps.test.ts`	Added comprehensive tests for both time and number formatting on scatter chart x-axes
`controlPanel.test.ts`	Added tests validating visibility logic for time and number format controls
`types.ts`	Extended form data type definition to include `xAxisNumberFormat` property
`transformProps.ts`	Implemented conditional formatter selection based on x-axis data type (Temporal vs Numeric)
`constants.ts`	Added default value 'SMART_NUMBER' for `xAxisNumberFormat`
`controlPanel.tsx`	Added visibility-controlled UI controls for time and number formatting with data-type-specific logic
`sharedControls.tsx`	Defined reusable `x_axis_number_format` control configuration

superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts

superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts

rusackas · 2025-11-12T18:48:07Z

Looking at some of the failing CI stuff, this PR might need a rebase, pulling in the latest changes from master to resolve a couple of the items (at least I hope it will fix the typescript issue I'm currently seeing).

alex241728 · 2025-11-12T21:09:32Z

Looking at some of the failing CI stuff, this PR might need a rebase, pulling in the latest changes from master to resolve a couple of the items (at least I hope it will fix the typescript issue I'm currently seeing).

@rusackas I have solved the suggestions provided by copilot. However, there is one thing I cannot solve in the pre-commit checks, which is provided in the quote. By the way, the transformProps.test for bar chart contains the same superTheme from the same file. It has the type error too.

Type checking 3 changed TypeScript files...
Running targeted type check on 3 files...
plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20:31 - error TS6305: Output file '/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts' has not been built from source file '/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
20 import { supersetTheme } from '@apache-superset/core/ui';
~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33:31 - error TS6305: Output file '/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts' has not been built from source file '/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
33 import { supersetTheme } from '@apache-superset/core/ui';
~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors in 2 files.
Errors Files
1 plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20
1 plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33
Failed to execute type checking: Type check failed with exit code 2

alex241728 · 2025-11-13T15:14:02Z

Looking at some of the failing CI stuff, this PR might need a rebase, pulling in the latest changes from master to resolve a couple of the items (at least I hope it will fix the typescript issue I'm currently seeing).

@rusackas I have solved the suggestions provided by copilot. However, there is one thing I cannot solve in the pre-commit checks, which is provided in the quote. By the way, the transformProps.test for bar chart contains the same superTheme from the same file. It has the type error too.
Type checking 3 changed TypeScript files...
Running targeted type check on 3 files...
plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20:31 - error TS6305: Output file '/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts' has not been built from source file '/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
20 import { supersetTheme } from '@apache-superset/core/ui';
plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33:31 - error TS6305: Output file '/Users/alex241728/superset/superset-frontend/packages/superset-core/lib/ui/index.d.ts' has not been built from source file '/Users/alex241728/superset/superset-frontend/packages/superset-core/src/ui/index.ts'.
33 import { supersetTheme } from '@apache-superset/core/ui';
Found 2 errors in 2 files.
Errors Files
1 plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:20
1 plugins/plugin-chart-echarts/test/Timeseries/Scatter/transformProps.test.ts:33
Failed to execute type checking: Type check failed with exit code 2

The error is fixed by

cd superset-frontend
npm run plugins:build

github-actions · 2025-11-14T00:25:54Z

🎪 Showtime is building environment on GHA for feeb12a

github-actions · 2025-11-14T00:39:25Z

🎪 Showtime deployed environment on GHA for feeb12a

• Environment: http://35.89.8.79:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

rusackas

Looks good to me! Thanks for the contribution!

Co-authored-by: Vincent <vincent.trung4@gmail.com>

pull-request-size bot added the size/M label Oct 30, 2025

github-actions bot added plugins packages labels Oct 30, 2025

dosubot bot added the viz:charts:scatterplot Related to the Scatterplot chart label Oct 30, 2025

korbit-ai bot suggested changes Oct 30, 2025

View reviewed changes

bito-code-review bot reviewed Oct 30, 2025

View reviewed changes

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx Outdated Show resolved Hide resolved

sadpandajoe requested review from rusackas and villebro October 30, 2025 18:12

alex241728 force-pushed the issue-32902-fix branch from f6a95e7 to a342a3d Compare November 4, 2025 17:28

pull-request-size bot added size/L and removed size/M labels Nov 5, 2025

alex241728 force-pushed the issue-32902-fix branch from b6069e4 to 91c3f48 Compare November 6, 2025 00:02

alex241728 force-pushed the issue-32902-fix branch from 090954e to d4497df Compare November 9, 2025 04:31

rusackas requested a review from Copilot November 12, 2025 17:27

Copilot started reviewing on behalf of rusackas November 12, 2025 17:28 View session

Copilot finished reviewing on behalf of rusackas November 12, 2025 17:31

Copilot AI reviewed Nov 12, 2025

View reviewed changes

alex241728 force-pushed the issue-32902-fix branch from 30c5b29 to 33df01b Compare November 12, 2025 21:00

alex241728 and others added 3 commits November 13, 2025 10:11

add more formats

f193046

complete fixing

9d32484

Clean up debug message

b183d7b

alex241728 and others added 5 commits November 13, 2025 10:11

control panel test

4aa504d

transform props test

bd9dbf3

precommit

f1aded7

modify test

c49c0f7

solve copilot suggestions

feeb12a

alex241728 force-pushed the issue-32902-fix branch from 33df01b to feeb12a Compare November 13, 2025 15:12

rusackas added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Nov 14, 2025

rusackas approved these changes Nov 14, 2025

View reviewed changes

rusackas merged commit 001b6cb into apache:master Nov 14, 2025
68 checks passed

aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Nov 17, 2025

feat: Floating Point Formatting for Scatter Point Chart (apache#35915)

826876d

Co-authored-by: Vincent <vincent.trung4@gmail.com>

kshi020302 pushed a commit to jl141/superset that referenced this pull request Nov 30, 2025

feat: Floating Point Formatting for Scatter Point Chart (apache#35915)

fde4c47

Co-authored-by: Vincent <vincent.trung4@gmail.com>

feat: Floating Point Formatting for Scatter Point Chart #35915

feat: Floating Point Formatting for Scatter Point Chart #35915

Uh oh!

Conversation

alex241728 commented Oct 30, 2025 • edited by sadpandajoe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bito-code-review bot commented Oct 30, 2025

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #2e97c7

Uh oh!

Uh oh!

sadpandajoe commented Oct 30, 2025

Uh oh!

rusackas commented Nov 3, 2025

Uh oh!

rusackas commented Nov 5, 2025

Uh oh!

alex241728 commented Nov 6, 2025

Uh oh!

sadpandajoe commented Nov 6, 2025

Uh oh!

alex241728 commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rusackas commented Nov 12, 2025

Uh oh!

alex241728 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex241728 commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alex241728 commented Oct 30, 2025 •

edited by sadpandajoe

Loading

korbit-ai bot left a comment •

edited

Loading

bito-code-review bot left a comment •

edited

Loading

alex241728 commented Nov 12, 2025 •

edited

Loading