test(useThemeMenuItems): fix race conditions by awaiting all userEvent calls

[sadpandajoe]

SUMMARY

Fixed race conditions in useThemeMenuItems test suite by adding await to all 20 unawaited userEvent calls (16 hover + 4 click). This prevents intermittent test failures caused by queries executing before async user interactions complete.

• Awaited all userEvent.hover() calls (16 occurrences)
• Awaited all userEvent.click() calls (4 occurrences)
• Follows established pattern from commit 4932f3522f (DatasourceControl fix)
• Aligns with React Testing Library best practices

BEFORE/AFTER

Before:

userEvent.hover(await screen.findByRole('menuitem'));
const menu = await findMenuWithText('Light');

After:

await userEvent.hover(await screen.findByRole('menuitem'));
const menu = await findMenuWithText('Light');

TESTING INSTRUCTIONS

Run the test suite multiple times to verify consistency:

npm run test -- useThemeMenuItems.test.tsx
npm run test -- useThemeMenuItems.test.tsx
npm run test -- useThemeMenuItems.test.tsx

Expected result: All 20 tests pass consistently across multiple runs with no race condition warnings.

Validation performed:

• ✅ 4 consecutive test runs: 20/20 tests passing each time
• ✅ No "unmounted component" warnings
• ✅ All pre-commit hooks passing

ADDITIONAL INFORMATION

This fix addresses potential flakiness by ensuring that async hover and click actions complete before subsequent queries and assertions execute. The @testing-library/user-event library returns Promises for all user interactions, which must be awaited to prevent race conditions.

Similar fixes have been applied across the codebase (28+ test files properly await userEvent calls). This change brings useThemeMenuItems.test.tsx in line with established testing patterns.

🤖 Generated with Claude Code

[bito-code-review]

Code Review Agent Run #84dada

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 49653de..49653de

  • superset-frontend/src/hooks/useThemeMenuItems.test.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[bito-code-review]

Interaction Diagram by Bito

sequenceDiagram
participant TestRunner as Test Runner
participant TestFile as useThemeMenuItems.test.tsx<br/>🔄 Updated | ●●○ Medium
participant UserEvent as userEvent (Testing Library)<br/>●●○ Medium
participant ScreenAPI as screen (Testing Library)
participant Hook as useThemeMenuItems Hook
participant Component as TestComponent
Note over TestFile: All userEvent.hover() and<br/>userEvent.click() calls now awaited
TestRunner->>TestFile: Execute test suite
TestFile->>Component: renderThemeMenu()
Component->>Hook: useThemeMenuItems(props)
Hook-->>Component: Return MenuItem
TestFile->>UserEvent: await userEvent.hover(menuitem)
UserEvent-->>TestFile: Hover action completed
TestFile->>ScreenAPI: findByRole/queryByText
ScreenAPI-->>TestFile: Return menu element
TestFile->>UserEvent: await userEvent.click(element)
UserEvent-->>TestFile: Click action completed
TestFile->>TestRunner: Assert results

Loading

Critical path: Test Runner -> useThemeMenuItems.test.tsx -> userEvent (Testing Library) -> screen (Testing Library) -> Hook

Note: All userEvent async operations (hover, click) now properly await their promises. This ensures test stability by waiting for DOM updates before assertions. No changes to the actual hook implementation; only test synchronization improved.