-
Notifications
You must be signed in to change notification settings - Fork 841
Integrate Python driver examples into automated build process (master) #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Integrate Python driver examples into automated build process (master) #3280
Conversation
…ate for TinkerPop 4 Changes Made: - Added example execution to gremlin-python-integration-tests container in docker-compose.yml - Made server URLs configurable via environment variables - Added configurable vertex labels via VERTEX_LABEL environment variable - Updated protocol from WebSocket (ws://) to HTTP for TinkerPop 4 compatibility - Updated serializer from GraphBinarySerializersV1 to GraphBinarySerializersV4 - Fixed edge creation syntax using __.V() wrapper for TinkerPop 4 from()/to() compatibility - Migrated example authentication from parameters to auth functions (basic(), sigv4()) - Added AWS SigV4 authentication examples for permanent and temporary credentials
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3280 +/- ##
============================================
+ Coverage 77.87% 78.37% +0.50%
- Complexity 13578 14598 +1020
============================================
Files 1015 1068 +53
Lines 59308 61893 +2585
Branches 6835 7384 +549
============================================
+ Hits 46184 48509 +2325
+ Misses 10817 10799 -18
- Partials 2307 2585 +278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please add a changelog entry |
| rc = DriverRemoteConnection( | ||
| 'ws://localhost:8182/gremlin', 'g', | ||
| username="", password="", kerberized_service='', | ||
| message_serializer=GraphBinarySerializersV1(), graphson_reader=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this example be retained which is demonstrating how the graph binary serializer can be configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added with_configs() example in 61c0e77, showcasing graph binary serializer configuration. Are there any other configurations that should be showcased here?
|
VOTE +1 |
2 similar comments
|
VOTE +1 |
|
VOTE +1 |
This PR is a follow-up to #3231 and includes the integration of Python driver examples into the automated build process, as well as the updates needed to make the examples work against the
mastercode.Changes Made:
Updates for
master: