Skip to content

Conversation

@kirill-stepanishin
Copy link
Contributor

@kirill-stepanishin kirill-stepanishin commented Nov 14, 2025

This PR is a follow-up to #3231 and includes the integration of Python driver examples into the automated build process, as well as the updates needed to make the examples work against the master code.

Changes Made:

  • Added example execution to gremlin-python-integration-tests container in docker-compose.yml
  • Made server URLs configurable via environment variables
  • Added configurable vertex labels via VERTEX_LABEL environment variable
  • Update root-level examples to be consistent with dev-level examples

Updates for master:

  • Updated protocol from WebSocket (ws://) to HTTP
  • Updated serializer from GraphBinarySerializersV1 to GraphBinarySerializersV4
  • Fixed edge creation syntax using __.V() wrapper for TinkerPop 4 from()/to() compatibility
  • Migrated example authentication from parameters to auth functions

…ate for TinkerPop 4

Changes Made:
- Added example execution to gremlin-python-integration-tests container in docker-compose.yml
- Made server URLs configurable via environment variables
- Added configurable vertex labels via VERTEX_LABEL environment variable
- Updated protocol from WebSocket (ws://) to HTTP for TinkerPop 4 compatibility
- Updated serializer from GraphBinarySerializersV1 to GraphBinarySerializersV4
- Fixed edge creation syntax using __.V() wrapper for TinkerPop 4 from()/to() compatibility
- Migrated example authentication from parameters to auth functions (basic(), sigv4())
- Added AWS SigV4 authentication examples for permanent and temporary credentials
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.37%. Comparing base (cfd6889) to head (61c0e77).
⚠️ Report is 691 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3280      +/-   ##
============================================
+ Coverage     77.87%   78.37%   +0.50%     
- Complexity    13578    14598    +1020     
============================================
  Files          1015     1068      +53     
  Lines         59308    61893    +2585     
  Branches       6835     7384     +549     
============================================
+ Hits          46184    48509    +2325     
+ Misses        10817    10799      -18     
- Partials       2307     2585     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirill-stepanishin kirill-stepanishin marked this pull request as ready for review November 14, 2025 19:22
@andreachild
Copy link
Contributor

Please add a changelog entry

rc = DriverRemoteConnection(
'ws://localhost:8182/gremlin', 'g',
username="", password="", kerberized_service='',
message_serializer=GraphBinarySerializersV1(), graphson_reader=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this example be retained which is demonstrating how the graph binary serializer can be configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added with_configs() example in 61c0e77, showcasing graph binary serializer configuration. Are there any other configurations that should be showcased here?

@andreachild
Copy link
Contributor

VOTE +1

2 similar comments
@Cole-Greer
Copy link
Contributor

VOTE +1

@xiazcy
Copy link
Contributor

xiazcy commented Nov 20, 2025

VOTE +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants