[ZEPPELIN-6212] Fix IRInterpreterTest.testZShow() for R 4.0+ compatibility #5012
Conversation
lee-ji-an
force-pushed
the
ZEPPELIN-6212
branch
from
4c32c7e to
e5ac08b
Compare
|
Could you please update the PR title to be a complete sentence? This helps provide clearer context when browsing the commit or PR history. Thanks! |
lee-ji-an
changed the title
Thank you for the review! I've updated the PR title to be a complete sentence as requested. |
|
@lee-ji-an I think we'd better add a test case for both environments using github actions. |
@jongyoul I agree that testing both R 3.x and R 4.x environments would provide better coverage. |
| - r-ggplot2 | ||
| - r-irkernel | ||
| - r-shiny | ||
| - r-googlevis No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of this file.
| assertEquals("<font color=red>Results are limited by 1 rows.</font>\n", | ||
| resultMessages.get(1).getData()); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please add a blank line at the end of this file.
| - r-ggplot2 | ||
| - r-irkernel | ||
| - r-shiny | ||
| - r-googlevis |
There was a problem hiding this comment.
Please add a blank line at the end of this file.
| - r-ggplot2 | ||
| - r-irkernel | ||
| - r-shiny | ||
| - r-googlevis |
There was a problem hiding this comment.
Please add a blank line at the end of this file.
3 participants
What is this PR for?
This PR fixes the
IRInterpreterTest.testZShow()test failure caused by R 4.0+ default behavior change.The test was failing because R 4.0+ changed the default
stringsAsFactorsfromTRUEtoFALSE, causing the test to expect numeric factor levels but receive actual string values.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
./mvnw test -pl rlang -Dtest=IRInterpreterTest#testZShowScreenshots (if appropriate)
N/A
Questions: