[Follow up PR] Make HCOMPRESS Support tiles not along the first two dimensions#56
Draft
Cadair wants to merge 40 commits intoaperiosoftware:fits-byte-compress-decompressfrom
Draft
[Follow up PR] Make HCOMPRESS Support tiles not along the first two dimensions#56Cadair wants to merge 40 commits intoaperiosoftware:fits-byte-compress-decompressfrom
Cadair wants to merge 40 commits intoaperiosoftware:fits-byte-compress-decompressfrom
Conversation
…actly with SUBTRACTIVE_DITHER_2
This commit should be able to be dropped / modified when we actually remove the unused bits of cfitsio.
This validates the case where the shape for a tile is passed incorrectly to the C wrapper
|
👋 Thank you for your draft pull request! Do you know that you can use |
Cadair
force-pushed
the
fits-byte-compress-decompress
branch
2 times, most recently
from
863e4f8 to
8ac61d9
Compare
Cadair
force-pushed
the
fits-byte-compress-decompress
branch
3 times, most recently
from
a93c06e to
9d19273
Compare
astrofrog
force-pushed
the
fits-byte-compress-decompress
branch
5 times, most recently
from
7278254 to
1ed7e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered that Astropy currently doesn't support this, but it should be possible to make it work so here we are.