Skip to content

Fix validation errors when defining multiple query parameters on an operation using the :property template valid + property restriction. #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix validation errors when defining multiple query parameters on an operation using the :property template valid + property restriction. #7461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ public function create(string $resourceClass): ResourceMetadataCollection
/**
* @return array{propertyNames: string[], properties: array<string, ApiProperty>}
*/
private function getProperties(string $resourceClass, ?Parameter $parameter = null): array
private function getProperties(string $resourceClass, ?Parameter $parameter = null, ?string $key = null): array
{
$k = $resourceClass.($parameter?->getProperties() ? ($parameter->getKey() ?? '') : '');
$k = $resourceClass.($parameter?->getProperties() ? ($parameter->getKey() ?? ($key ?? '')) : '');
if (isset($this->localPropertyCache[$k])) {
return $this->localPropertyCache[$k];
}
Expand All @@ -120,7 +120,7 @@ private function getDefaultParameters(Operation $operation, string $resourceClas
$propertyNames = $properties = [];
$parameters = $operation->getParameters() ?? new Parameters();
foreach ($parameters as $key => $parameter) {
['propertyNames' => $propertyNames, 'properties' => $properties] = $this->getProperties($resourceClass, $parameter);
['propertyNames' => $propertyNames, 'properties' => $properties] = $this->getProperties($resourceClass, $parameter, $key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bother's me is that a parameter should always have akey, would it be possible to change the loop and do:

foreach ($parameters as $key => $parameter) {
    if (!$parameter->getKey()) {
        $parameter = $parameter->withKey($key);
    }

if (null === $parameter->getProvider() && (($f = $parameter->getFilter()) && $f instanceof ParameterProviderFilterInterface)) {
$parameters->add($key, $parameter->withProvider($f->getParameterProvider()));
}
Expand Down
Loading