Fix netlify direct links in deploy previews#49
Merged
Conversation
✅ Deploy Preview for emberarchive ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NEStock
changed the title
guittari
approved these changes
May 8, 2025
gbezold1
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Netlify does not by default correctly route SPAs, so direct links to pages like /projects were not working on previous PR, but these kind of links will not work on on this PR + in future PRs.
Working Example: https://deploy-preview-49--emberarchive.netlify.app/projects
Former, not working example: https://deploy-preview-47--emberarchive.netlify.app/projects
Note: This is fully just to support deploy previews in our PRs, unrelated to real deployments