Skip to content

Set environment vars to set vendor-specific dandi-schema used by the DANDI instance#47

Merged
NEStock merged 3 commits intoaplbrain:61-sync-fork-nov-10-weekfrom
candleindark:vendor-envirn-apl
Nov 10, 2025
Merged

Set environment vars to set vendor-specific dandi-schema used by the DANDI instance#47
NEStock merged 3 commits intoaplbrain:61-sync-fork-nov-10-weekfrom
candleindark:vendor-envirn-apl

Conversation

@candleindark
Copy link
Copy Markdown

@candleindark candleindark commented Oct 1, 2025

dandi/dandi-schema#294 enables vendor-configurable metadata models in dandi-schema.

This PR sets environment variables to configure the metadata models in dandi-schema with EMBER specific info. It is comparable to dandi#224 in https://github.com/dandi/dandi-infrastructure and should be merged after dandi#224 is merged.

TODOs:

@NEStock
Copy link
Copy Markdown
Member

NEStock commented Oct 7, 2025

@candleindark should we also ensure that we have at least up to dandi/dandi-archive#2386 pulled into our fork before hitting merge?

@candleindark
Copy link
Copy Markdown
Author

@candleindark should we also ensure that we have at least up to dandi/dandi-archive#2386 pulled into our fork before hitting merge?

No, this is independent of that one. All this one does is to introduce some env vars, it shouldn't affect the current operation in any way. With that said, I want to wait until dandi#224 is merged before you merge this one though since this repo is a fork of https://github.com/dandi/dandi-infrastructure.

@NEStock
Copy link
Copy Markdown
Member

NEStock commented Oct 7, 2025

@candleindark should we also ensure that we have at least up to dandi/dandi-archive#2386 pulled into our fork before hitting merge?

No, this is independent of that one. All this one does is to introduce some env vars, it shouldn't affect the current operation in any way. With that said, I want to wait until dandi#224 is merged before you merge this one though since this repo is a fork of https://github.com/dandi/dandi-infrastructure.

Sounds good thank you!

@candleindark
Copy link
Copy Markdown
Author

@NEStock dandi#224 has been approved. It believe it will be merged very soon. It is unlikely to change. You can merge this PR now or continue to wait. But make sure you have this PR merged and released before Stage 2b in dandi/dandi-schema#299 merge and released.

@NEStock
Copy link
Copy Markdown
Member

NEStock commented Oct 30, 2025

@NEStock dandi#224 has been approved. It believe it will be merged very soon. It is unlikely to change. You can merge this PR now or continue to wait. But make sure you have this PR merged and released before Stage 2b in dandi/dandi-schema#299 merge and released.

@candleindark Thank you for the update! We have a few dandi-archive & dand-infrastructure updates to pull into our fork, so ideally we can get those in first (& soon) and then do this next

@NEStock NEStock changed the base branch from apl-setup to 61-sync-fork-nov-10-week November 10, 2025 19:20
@NEStock NEStock merged commit bab10ab into aplbrain:61-sync-fork-nov-10-week Nov 10, 2025
@NEStock NEStock mentioned this pull request Nov 10, 2025
10 tasks
@candleindark candleindark deleted the vendor-envirn-apl branch November 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants