Fix on people page name #371
Conversation
The people page name must be singular.
abea
left a comment
abea
left a comment
There was a problem hiding this comment.
I would be a good practice to set the name property on the pieces pages module to the singular form of the directory name. That said it's not specified that way here.
If you'd like, you could add a step showing very basic config for lib/modules/people-pages/index.js including that name property. You would then also change the reference on L26.
|
By default the '-pages' is changed to '-page', so the example is not intuitive for the users. (they maybe dont know they can change the name of the piece-pages)
|
abea
left a comment
abea
left a comment
There was a problem hiding this comment.
You're right. I got confused myself because of the permissiveness of A2's page templates. Thank goodness we went all singular in A3.
| name: 'home', | ||
| label: 'Home' | ||
| }, | ||
| // Our new page type for displaying people |
There was a problem hiding this comment.
Please add a comment here on a new line: "Note that the -pages suffix is converted to the singular -page for the document type.
3 participants
The people page name must be singular.