Skip to content

Handling double percent encoding at the start of the string #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueWarg merged 1 commit into from
Feb 21, 2025
Merged

Handling double percent encoding at the start of the string #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const NON_NUMBERED_PLACEHOLDER_REGEX: &str = concatcp!(
PLACEHOLDER_TYPES,
")"
);
const SINGLE_PERCENT_REGEX: &str = r"([^%][%][^%]|[^%][%]$|^[%]$)";
const SINGLE_PERCENT_REGEX: &str = r"([^%][%][^%]|[^%][%]$|^[%]$|^[%][^%])";

fn key_from_locale_value_map(
name: String,
Expand Down Expand Up @@ -502,11 +502,11 @@ fn parses_double_quotes_with_proper_escaping() {

#[test]
fn replaces_percent_with_double_percent_wihout_placeholders() {
let input = "100% Lorem ipsum amet 8% and %% untouched, ending with 42%".to_string();
let input = "% of 100% Lorem ipsum amet 8% and %% untouched, ending with 42%".to_string();
let result = parse_localized_string_value(input).unwrap();
assert_eq!(
result,
"100%% Lorem ipsum amet 8%% and %% untouched, ending with 42%%"
"%% of 100%% Lorem ipsum amet 8%% and %% untouched, ending with 42%%"
);
}

Expand Down