Skip to content

Fix compiler warning in LocalOCILayoutClient #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityaramani merged 1 commit into from
Jun 5, 2025
Merged

Fix compiler warning in LocalOCILayoutClient #19

adityaramani merged 1 commit into from
Jun 5, 2025

Conversation

@adityaramani
Copy link
Contributor

@adityaramani adityaramani commented Jun 4, 2025

Resolves warning

LocalOCILayoutClient.swift:87:37: warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 85 |             var hasher = SHA256()
 86 | 
 87 |             for try await buffer in input {
    |                                     `- warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 88 |                 wrote += buffer.readableBytes
 89 |                 try buffer.withUnsafeReadableBytes { pointer in

@adityaramani
Fix compiler warning
ed4d734 
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
@adityaramani adityaramani requested a review from dkovba June 4, 2025 23:16
dkovba
dkovba approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@dkovba dkovba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adityaramani adityaramani merged commit 530126f into main Jun 5, 2025
2 checks passed
katiewasnothere pushed a commit that referenced this pull request Jun 5, 2025
@adityaramani @katiewasnothere
Fix compiler warning in LocalOCILayoutClient (#19)
3ee87d9 
Resolves the warning
```
LocalOCILayoutClient.swift:87:37: warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 87 |             for try await buffer in input {
    |                                     `- warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 88 |                 wrote += buffer.readableBytes
 89 |                 try buffer.withUnsafeReadableBytes { pointer in
```

Signed-off-by: Aditya Ramani <a_ramani@apple.com>
katiewasnothere pushed a commit that referenced this pull request Jun 5, 2025
@adityaramani @katiewasnothere
Fix compiler warning in LocalOCILayoutClient (#19)
c2e2219 
Resolves the warning
```
LocalOCILayoutClient.swift:87:37: warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 87 |             for try await buffer in input {
    |                                     `- warning: capture of non-sendable type 'T.AsyncIterator.Type' in an isolated closure
 88 |                 wrote += buffer.readableBytes
 89 |                 try buffer.withUnsafeReadableBytes { pointer in
```

Signed-off-by: Aditya Ramani <a_ramani@apple.com>
@katiewasnothere katiewasnothere deleted the users/a_ramani/fix-warning branch June 6, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkovba dkovba dkovba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adityaramani @dkovba