[OrderedDictionary] mapValues with key context#556
Draft
tayloraswift wants to merge 4 commits intoapple:mainfrom
Draft
[OrderedDictionary] mapValues with key context#556tayloraswift wants to merge 4 commits intoapple:mainfrom
tayloraswift wants to merge 4 commits intoapple:mainfrom
Conversation
dnadoba
reviewed
Jan 8, 2026
Member
dnadoba
left a comment
There was a problem hiding this comment.
This looks very good. Thank you!
swift-collections is not governed by swift-evolution and this change can be independently reviewed and merged.
With that being said, it would be great if we end up with the same name.
I think as your swift-evolution pitch for Dictionary is still moving we should still wait unless this get's stuck. This might already be what you had in mind as this is a Draft PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation for swiftlang/swift-evolution#3060
Checklist