[SC-???] [WIP] Do not request sensitive information unless it's going to be displayed#410
Draft
UserNotFound wants to merge 5 commits intomasterfrom
Draft
[SC-???] [WIP] Do not request sensitive information unless it's going to be displayed#410UserNotFound wants to merge 5 commits intomasterfrom
UserNotFound wants to merge 5 commits intomasterfrom
Conversation
UserNotFound
force-pushed
the
no-sens-unless-required
branch
from
177f4d8 to
1e53b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
In a number of cases, there is sensitive information we want to audit (track with Activity) when the user retrieves said information. So, we need to conditionally ask the API to not return that information, unless it's actually needed. Most likely we want the sensitive info when the users asks for JSON output, but there are also cases where it's not returned then, even.