Update Selenium to 4.36.0 +semver:feature

[mialeska]

Fix javadocs annotations

PR Details

Related Issue Link:

How Has This Been Tested

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[coderabbitai]

Walkthrough

This PR updates two project dependencies—guava from 33.4.8-jre to 33.5.0-jre and selenium-java from 4.35.0 to 4.36.0 in pom.xml—and improves Javadoc documentation across three interface and utility classes with added type parameter documentation and corrected grammar.

Changes

Cohort / File(s)	Summary
Dependency Updates pom.xml	Updated com.google.guava:guava from 33.4.8-jre to 33.5.0-jre and org.seleniumhq.selenium:selenium-java from 4.35.0 to 4.36.0
Javadoc Documentation Improvements src/main/java/aquality/selenium/core/elements/interfaces/IElementFactory.java, src/main/java/aquality/selenium/core/elements/interfaces/IParent.java, src/main/java/aquality/selenium/core/visualization/ImageFunctions.java	Enhanced Javadoc comments with explicit type parameter sections for generic methods, corrected grammar ("more then zero" → "more than zero"), and added @throws IOException documentation for IO-related methods

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

These are routine dependency version bumps and cosmetic documentation improvements with no functional logic changes, API modifications, or implementation alterations required.

Possibly related PRs

• Update Selenium to 4.27.0 +semver:feature #98: Updates both guava and selenium-java dependencies in pom.xml with version bumps
• Update Selenium to 4.28.1 +semver:feature #100: Modifies the same dependency declarations (guava and selenium) with version updates
• Update Selenium to 4.28.1 +semver:feature #99: Contains concurrent guava and selenium-java dependency version bumps in pom.xml

Suggested labels

dependencies

Poem

🐰 A rabbit hops through dependency trees,
Updating guava and Selenium with ease!
Docs tidied up, grammar refined,
No breaking changes left behind—
Our burrow stands sturdier, more grand,
Ready to test across all the land! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description follows the template structure but leaves critical sections incomplete. The "Related Issue Link" section is empty, yet the template explicitly notes that "This project only accepts pull requests related to open issues," making this a required element. Additionally, the "How Has This Been Tested" section contains no information despite the template requesting detailed testing descriptions. While the Checklist section is partially completed with five relevant items addressed (including claims that code follows style guidelines, documentation was updated, and tests passed), the absence of issue linkage and testing details represents a significant gap in meeting the template requirements.	To resolve this failure, add the missing required information: provide a link to the related issue in the "Related Issue Link" field (as stated in the template requirements), and fill in the "How Has This Been Tested" section with details about how the Javadoc changes and dependency updates were validated. These sections are essential per the repository's template structure and the explicit guidance within the template comments.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Update Selenium to 4.36.0 +semver:feature" accurately references a real component of the changeset—the selenium-java dependency is indeed updated from 4.35.0 to 4.36.0, as documented in the pom.xml changes. However, the changeset also includes a Guava dependency update (33.4.8-jre to 33.5.0-jre) and multiple Javadoc corrections across three Java interface files (IElementFactory.java, IParent.java, and ImageFunctions.java). The PR description's primary note is "Fix javadocs annotations," which suggests the Javadoc improvements may be the central focus, yet the title emphasizes only the Selenium update, creating a mismatch between the title's emphasis and the description's stated primary change.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch enhancement/update-to-selenium-4.36.0

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f2abac and 8f97c28.

📒 Files selected for processing (4)

• pom.xml (2 hunks)
• src/main/java/aquality/selenium/core/elements/interfaces/IElementFactory.java (30 hunks)
• src/main/java/aquality/selenium/core/elements/interfaces/IParent.java (16 hunks)
• src/main/java/aquality/selenium/core/visualization/ImageFunctions.java (1 hunks)

🔇 Additional comments (4)

pom.xml (1)

112-112: Dependency versions are current and secure.

Both Selenium 4.36.0 and Guava versions are valid releases. No direct vulnerabilities have been found for Guava 33.5.0-jre.

However, the PR checklist indicates "I have added tests to cover my changes" is unchecked, yet these dependency updates should ideally have some verification. Consider running the existing test suite to validate compatibility.

Also applies to: 122-122

src/main/java/aquality/selenium/core/visualization/ImageFunctions.java (1)

124-124: Good Javadoc improvement.

Adding the @throws IOException documentation aligns with best practices since the method signature already declares this exception. This clarifies to callers what errors they should handle.

src/main/java/aquality/selenium/core/elements/interfaces/IParent.java (1)

116-116: Javadoc improvements are complete and consistent.

The updates across all findChildElements overloads correctly add:

• Explicit <T> type parameter documentation for generic methods
• Grammatical fix from "more then zero" to "more than zero"

These documentation enhancements improve API clarity without altering method signatures or behavior. The pattern is consistently applied.

Also applies to: 128-129, 142-142, 155-156, 170-170, 183-184, 198-198, 213-213, 224-224, 236-237, 251-251, 265-266, 280-280, 293-294, 309-309, 325-325

src/main/java/aquality/selenium/core/elements/interfaces/IElementFactory.java (1)

186-186: Javadoc documentation enhancements are thorough and consistent.

The extensive updates across all findChildElements and findElements overloads systematically:

• Document generic type parameters with <T> entries
• Correct grammatical issues ("more then zero" → "more than zero")

These improvements enhance code clarity for API consumers while maintaining full backward compatibility. The documentation style is consistent with the parallel updates in IParent.java.

Also applies to: 200-201, 216-216, 231-232, 264-265, 281-281, 310-310, 324-325, 340-340, 355-355, 373-373, 388-389, 405-405, 422-422, 434-435, 449-449, 463-463, 477-478, 491-491, 503-504, 519-520, 533-533, 545-546, 560-560, 572-572, 585-586, 599-599, 611-612

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud