Add native cmake support #28
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For backwards compatibility, -D will continue to be interpreted as Python expression until 4.0 - Introduced a temporary variable -d/--define-value-type to switch to the proper interpretation when set to `str` Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Author
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
cmake/cmake
branch
from
2a34e71 to
54cd5ca
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
cmake/cmake
branch
2 times, most recently
from
5253b78 to
0a1bf9f
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
cmake/cmake
branch
from
0a1bf9f to
03eba55
Compare
LecrisUT
commented
Feb 14, 2024
| # Append the name of the generated files to the fypp_files | ||
| # TODO: This might duplicate the file names when dependency is rerun | ||
| COMMAND ${CMAKE_COMMAND} -E echo ${out_file} >> ${target_fypp_files} | ||
| COMMAND ${Fypp_EXECUTABLE} -p ${define_flags} ${include_flags} ${source_path} ${out_path} |
Author
There was a problem hiding this comment.
Use either python -m fypp or pipx --spec /path/to/fypp/module
Author
|
I have various design notes for improvement if someone wants to pick this up again. |
I would be interested, yes |
Author
Cool, you can start by breaking up the PRs and ping me for review and I will share change proposals then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides helpful cmake interfaces:
Fypp_target_sourcesequivalent totarget_sources. This is the main interface that should be usedFypp_add_library=add_library+Fypp_target_sourcesFypp_add_executable=add_executable+Fypp_target_sourcesThe project is structured such that users can include fypp via
FetchContent, e.g.:Depends on #27, #29