Skip to content

Feat: add data to proposal actions json #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rekard0 merged 3 commits into from
Feb 18, 2025
Merged

Feat: add data to proposal actions json #39

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54719f
feat: add data to the output file
clauBv23 Feb 4, 2025
d839904
feat: add needed import
clauBv23 Feb 6, 2025
19a3a44
Merge branch 'main' into feat/add-data-to-proposal-actions-json
clauBv23 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions packages/contracts/deploy/20_new_version/23_publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ import {PluginRepo} from '../../typechain';
import {
findPluginRepo,
getPastVersionCreatedEvents,
impersonatedManagementDaoSigner,
isLocal,
pluginEnsDomain,
impersonatedManagementDaoSigner,
isValidAddress,
} from '../../utils/helpers';
import {PLUGIN_REPO_PERMISSIONS, uploadToPinata} from '@aragon/osx-commons-sdk';
import {PluginRepo__factory} from '@aragon/osx-ethers';
import {SignerWithAddress} from '@nomiclabs/hardhat-ethers/signers';
import {writeFile} from 'fs/promises';
import {ethers} from 'hardhat';
Expand Down Expand Up @@ -193,6 +194,26 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
} else {
// The deployer does not have `MAINTAINER_PERMISSION_ID` permission and we are not deploying to a production network,
// so we write the data into a file for a management DAO member to create a proposal from it.

const pluginRepoInterface = PluginRepo__factory.createInterface();
const versionData = {
_release: VERSION.release,
_pluginSetup: setup.address,
_buildMetadata: ethers.utils.hexlify(
ethers.utils.toUtf8Bytes(buildMetadataURI)
),
_releaseMetadata: ethers.utils.hexlify(
ethers.utils.toUtf8Bytes(releaseMetadataURI)
),
};

const calldata = pluginRepoInterface.encodeFunctionData('createVersion', [
versionData._release,
versionData._pluginSetup,
versionData._buildMetadata,
versionData._releaseMetadata,
]);

const data = {
proposalTitle: `Publish '${PLUGIN_CONTRACT_NAME}' plugin v${VERSION.release}.${VERSION.build}`,
proposalSummary: `Publishes v${VERSION.release}.${VERSION.build} of the '${PLUGIN_CONTRACT_NAME}' plugin in the '${ensDomain}' plugin repo.`,
Expand All @@ -202,16 +223,9 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
actions: [
{
to: pluginRepo.address,
createVersion: {
_release: VERSION.release,
_pluginSetup: setup.address,
_buildMetadata: ethers.utils.hexlify(
ethers.utils.toUtf8Bytes(buildMetadataURI)
),
_releaseMetadata: ethers.utils.hexlify(
ethers.utils.toUtf8Bytes(releaseMetadataURI)
),
},
value: 0,
data: calldata,
createVersion: versionData,
},
],
};
Expand Down
Loading