This repository was archived by the owner on May 22, 2025. It is now read-only.
Voting connector: Support vote statuses#336
Open
PJColombo wants to merge 5 commits intoaragon:masterfrom
Open
Conversation
|
|
PJColombo
changed the title
0xGabi
suggested changes
Nov 8, 2021
Contributor
0xGabi
left a comment
0xGabi
left a comment
There was a problem hiding this comment.
Well done! I left a minor suggestion.
I wonder if you consider using an enum for the status value instead of returning the string. What do you think of touching base with DeepDAO to know their preference about how to consume the status data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates both the Voting connector and subgraph in order to expose the vote status following the DeepDao's Gitcoin bounty requirements.
The vote status can be one of the following:
-Ongoing: The vote hasn't ended.
-Accepted: The vote ended and it's waiting to be executed (pending).
-Rejected: The vote ended and it didn't reach the minimum accepted quorum nor minimum support.
-Executed: The vote was enacted.
I didn't include
CreatednorStartedas I considered those to be redundant and could be encapsulated inOngoing.The same I did with
Endedsince we can consider a vote eitherAcceptedorRejectedwhen it has ended.If you want to quickly test the connector with these changes you can use a private subgraph that I deployed just for testing: https://thegraph.com/hosted-service/subgraph/pjcolombo/connect-voting-status
You only need to change the
VOTING_SUBGRAPH_URLvariable value here.