-
-
Notifications
You must be signed in to change notification settings - Fork 2k
added error saving vector store #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HarshitR2004 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks like ruff lint is failing: Found 1 error. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
+ Coverage 34.67% 42.25% +7.57%
==========================================
Files 131 136 +5
Lines 8703 9325 +622
==========================================
+ Hits 3018 3940 +922
+ Misses 5685 5385 -300 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dartpain I have fixed the code formating issue please look into the PR again |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@dartpain I have added the tests to improve the coverage, pls look at it |
ManishMadan2882
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HarshitR2004,
I tested this update by triggering no space left on my system(Linux) with the command
fallocate -l 11.5G /tmp/fill_disk_test.img where 11.5G is the available space (df -h )
The logs had the OSError: Unable to save vector store to temp/local/https://docs.docsgpt.cloud/: [Errno 28] No space left on device: '/tmp/tmp6_g7_z2t' as expected
the implementation is FAISS specific, but without the error handling proposed the TASK_STATUS remained in progress state which was an issue
Thanks for the update!
|
@ManishMadan2882 Thanks for the detailed testing and approval. Much appreciated. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
Why was this change needed? (You can also link to an open issue here)
Unhandled Vector Store Save Failures #2080
Fixed unhandled vector store save failures in the embedding pipeline that could cause data loss and application crashes. The
embed_and_store_documentsfunction lacked error handling aroundstore.save_local()calls which could lead to unexpected failures.Other information:
Improved observability with clear error messages distinguishing between different save failure types.