Open
Conversation
mariadalfonso
requested review from
lucalavezzo and
pmlugato
and removed request for
pmlugato
lucalavezzo
requested changes
Mar 26, 2026
Comment on lines
+50
to
+51
| or chat_app_config.get("agent_class") | ||
| or chat_app_config.get("pipeline", "CMSCompOpsAgent")) |
Collaborator
There was a problem hiding this comment.
we should not be reading from the chat app configs here
Comment on lines
+62
to
+64
| or chat_app_config.get("default_provider")) | ||
| default_model = (self.redmine_config.get("default_model") | ||
| or chat_app_config.get("default_model")) |
Collaborator
There was a problem hiding this comment.
we should not be reading from the chat app configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redmine reads default_provider and default_model from redmine_mailbox config, which are None since are were not sure.
Now
If redmine_mailbox has its own model config → uses that
If not → automatically picks from chat_app
No YAML duplication needed
this solve issue #533 (comment)