-
-
Notifications
You must be signed in to change notification settings - Fork 147
devel: import bumpbuddy out of date information #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cd4f5e3 to
10577b6
Compare
10577b6 to
d060bd0
Compare
anthraxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall awesome change, I haven't yet tested it locally, but except the small proposed changes this looks like it should work <3
|
Thanks for putting the work into this 🤗 |
|
| 'local_version': 100, | ||
| 'upstream_version': 100, | ||
| 'out_of_date': False, | ||
| 'issue': 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some json elements to not carry any issue property, so I'd suggest just to add a second test testing how process_package or the web code reacts to the missing issue property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are really wip, they need to be extended more :)
No description provided.