- 
                Notifications
    You must be signed in to change notification settings 
- Fork 277
Allow redefining ETHERNET_MAX_SOCK_NUM, ETHERNET_SPI_SPEED #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            vshymanskyy
  wants to merge
  6
  commits into
  arduino-libraries:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
vshymanskyy:master
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Replaces #168 | 
| Replaces #160 | 
| Memory usage change @ f2daaae 
 Click for full report table
 Click for full report CSV | 
use transfer(wbuf,rbuf,count) also for read
| Memory usage change @ daac848 
 Click for full report table
 Click for full report CSV | 
…for-read Revert "use transfer(wbuf,rbuf,count) also for read"
| Memory usage change @ 5276487 
 Click for full report table
 Click for full report CSV | 
| I've tested these patches and can confirm MAX_SOCK_NUM works. Thank you @vshymanskyy | 
      
        
              This comment was marked as duplicate.
        
        
      
    
  This comment was marked as duplicate.
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
MAX_SOCK_NUMandSPI_ETHERNET_SETTINGSare currently hard-coded, but there are many cases where one would like to override this. Currently, this requires patching the library.This PR adds 2 preprocessor definitions:
ETHERNET_MAX_SOCK_NUM,ETHERNET_SPI_SPEEDwhich can be easily overridden by the build system (like PlatformIO).Another related setting,
ETHERNET_LARGE_BUFFERSis already configurable externally.I.e. I was able to get 3.4 MBps download speed on ESP32 by applying the PIO configuration:
build_flags = -DETHERNET_SPI_SPEED=64000000 -DETHERNET_MAX_SOCK_NUM=2 -DETHERNET_LARGE_BUFFERSThe change should be completely backward compatible.