-
Notifications
You must be signed in to change notification settings - Fork 7
Add GitHub Actions workflow to check OpenAPI breaking changes #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2931fae
Add GitHub Actions workflow to check OpenAPI breaking changes
dido18 6645c9c
Update .github/workflows/openapi-spec.yml
dido18 9384d87
Update .github/workflows/openapi-spec.yml
dido18 852b3b0
Pin oasdiff installation to version 1.11.7
dido18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| name: Check for breaking OpenAPI changes | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| paths: | ||
| - "internal/api/docs/openapi.yaml" | ||
| workflow_dispatch: | ||
| inputs: | ||
| target_branch: | ||
| description: "Branch to compare against (used in manual runs)" | ||
| required: false | ||
| default: "main" | ||
|
|
||
| jobs: | ||
| oasdiff: | ||
| name: OASDiff Check | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Install oasdiff | ||
| run: go install github.com/oasdiff/oasdiff@v1.11.7 | ||
|
|
||
| - name: Add Go bin to PATH | ||
| run: echo "${HOME}/go/bin" >> $GITHUB_PATH | ||
|
|
||
| - name: Determine base branch and fetch OpenAPI file | ||
| id: get_base_openapi | ||
| run: | | ||
| BASE_BRANCH="${{ github.event.pull_request.base.ref || github.event.inputs.target_branch || 'main' }}" | ||
| echo "Comparing against base branch: $BASE_BRANCH" | ||
| git fetch origin "$BASE_BRANCH" | ||
| git show origin/"$BASE_BRANCH":internal/api/docs/openapi.yaml > /tmp/base-openapi.yaml \ | ||
| || (touch /tmp/base-openapi.yaml; echo "No base OpenAPI file found, using empty file.") | ||
|
|
||
| - name: Run oasdiff to check for breaking changes | ||
| run: | | ||
| if oasdiff breaking --format githubactions --filter-extension request-parameter-enum-value-added --fail-on ERR /tmp/base-openapi.yaml internal/api/docs/openapi.yaml; then | ||
| echo "✅ No breaking changes detected in OpenAPI spec." | ||
| else | ||
| echo "❌ Breaking changes detected! Please review the OpenAPI spec." | ||
| exit 1 | ||
| fi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?