Open
Conversation
Owner
|
Hey, very useful feature and I it works great on my Ubuntu PC, but I tried on my Mac and the scaling doesn't work how I saw on my PC (attached a video where the scaling doesn't appear at all, we just fullscreen and nothing else). Let me know if I did something wrong because I like this one a lot and want to merge it Screen.Recording.2023-08-12.at.6.13.36.PM.mov |
Owner
|
Another small thing is making sure that the fullscreen is reversible, which shouldn't be super hard to do. Right now since we just change the window aspects its impossible to reverse after hitting 'f' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Press 'f' to go fullscreen.
Probably camera size will not be not proportional to screen size, so expect some distortion.
If you prefer to keep aspect ratio, check the comment airdraw.py (line 104)