Skip to content

110 nsam reviewers require experimented problems data#111

Open
argaman-aloni wants to merge 11 commits intomainfrom
110-nsam-reviewers-require-experimented-problems-data
Open

110 nsam reviewers require experimented problems data#111
argaman-aloni wants to merge 11 commits intomainfrom
110-nsam-reviewers-require-experimented-problems-data

Conversation

@argaman-aloni
Copy link
Owner

No description provided.

Introduced trajectory statistics aggregation in NumericResultsCollector and defined TRAJECTORY_STATS_COLUMNS. Improved Plan-Miner process output logging using threading. Updated parallel experiment runner to select a specific trajectory and commented out semantic performance calculator initialization. Bumped pddl-plus-parser dependency to 3.16.4. Added utility script for copying matching trajectory files.
Refactored trajectory file iteration in ParallelExperimentRunner to process all files instead of a single index. Enabled semantic performance calculator initialization. Enhanced error logging in ExperimentTrajectoriesCreator for trajectory creation failures. Updated pddl-plus-parser to version 3.16.5. Added 'solving_time_per_problem' to SOLVING_STATISTICS and ensured sorted processing of test set problems in DomainValidator.
@argaman-aloni argaman-aloni linked an issue Dec 3, 2025 that may be closed by this pull request
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…nner should have solved the problem if given another try.
Replaces single 'action_distribution' metric with 'average', 'min', and 'max' action distribution statistics for more detailed analysis. Also imports numpy's mean function for accurate averaging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSAM reviewers require experimented problems data.

1 participant