chore(controller): remove underlying deprecated functions and add extra logging #25032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nitishfy <justnitish06@gmail.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
nitishfy
commented
Oct 22, 2025
| appList.Items = newItems | ||
| return appList, nil | ||
| }, | ||
| WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) { |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25032 +/- ##
==========================================
- Coverage 60.89% 60.84% -0.05%
==========================================
Files 351 351
Lines 60489 60531 +42
==========================================
Hits 36832 36832
- Misses 20736 20775 +39
- Partials 2921 2924 +3 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Oct 22, 2025
rumstead
reviewed
Oct 22, 2025
Signed-off-by: nitishfy <justnitish06@gmail.com>
ppapapetrou76
suggested changes
Oct 23, 2025
| log.Infof("Initializing ApplicationController: appResyncPeriod=%v, appHardResyncPeriod=%v, appResyncJitter=%v", appResyncPeriod, appHardResyncPeriod, appResyncJitter) | ||
|
|
||
| db := db.NewDB(namespace, settingsMgr, kubeClientset) | ||
| // use default rate limiter config if not provided |
There was a problem hiding this comment.
Do you think we really need this comment? It's apparent what the following line does.
Overall, if we need comments to explain the code, it's better to improve the code and remove the comments
| log.Info("Hydrator feature enabled; initializing hydrator subsystem") | ||
| ctrl.hydrator = hydrator.NewHydrator(&ctrl, appResyncPeriod, commitClientset, repoClientset, db) | ||
| } | ||
| // Apply kubectl concurrency limit if specified |
There was a problem hiding this comment.
Same here about comments
alexmt
requested changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application controller code is written pretty nicely but hasn't been properly documented. There are quite a few fields that were deprecated too which is still getting used. This PR documents the app controller code, remove the deprecated function and add better logs.
Checklist: