-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Exclude dependency docs from source tarball #16261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4042b32 to
e69a192
Compare
e69a192 to
8fd05e2
Compare
|
I was about to merge this, but decided to take one last look at |
8fd05e2 to
bd650bb
Compare
f21277e to
eda0aea
Compare
|
I found the issue. When executed on CircleCI, the shell apparently takes the I replaced it with two commands so now everything should be fine in CI as well. |
eda0aea to
3e97db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the size of the tarball is reduced and the docs of dependencies are not present.
3e97db9 to
809c719
Compare
Follow-up to #16256.
During the prerelease we discovered that
create_source_tarball.shpackages nlohmann-json docs as a part of our source. And it includes a bunch of unnecessary things, especially big images and rendered versions of the docs. For example:gh-pages/is 15 MB)range-v3we'd have it in there as well.Excluding
doc/anddocs/from these submodules shaves off almost half of the size of the source tarball (12.3 MB -> 7.3 MB).These things are essentially dead weight as I would not expect anyone to look for them in our archive (they'd more likely go the source repo or to their docs webpage) and they do not the affect compiler build.