Use more processors to build base builds. #9419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
moarproc
branch
2 times, most recently
from
0ff72e8 to
7b2f716
Compare
cameel
reviewed
Jul 15, 2020
.circleci/config.yml
Outdated
| docker: | ||
| - image: ethereum/solidity-buildpack-deps:emsdk-1.39.15-2 | ||
| environment: | ||
| NJOBS: 9 |
Collaborator
There was a problem hiding this comment.
In #9368 (comment) @ekpyron suggested using MAKEFLAGS for that.
Collaborator
There was a problem hiding this comment.
At least if it works, yeah :-).
cameel
reviewed
Jul 15, 2020
| -DTESTS=0 \ | ||
| .. | ||
| make -j 4 soljson | ||
| make -j "${NJOBS:-4}" soljson |
Collaborator
There was a problem hiding this comment.
Maybe you should also modify Travis config to set this variable? Or is it just that you're fine with the default and don't want to change it to anything higher right now?
ekpyron
approved these changes
Jul 15, 2020
Collaborator
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
Yep, that seems nicer to me! We should confirm that it actually works as expected (i.e. look at the runtimes), though :-).
Contributor
Author
|
The time for the build only (excluding setting up the docker image since the time for that can vary) goes from 8.5 minutes down to 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.