feat: default argument values for slash commands#217
Open
ariane-emory wants to merge 10 commits intodevfrom
Open
feat: default argument values for slash commands#217ariane-emory wants to merge 10 commits intodevfrom
ariane-emory wants to merge 10 commits intodevfrom
Conversation
Extracts argument substitution logic from session/prompt.ts to config/substitute.ts for reuse by other features like the expand command. Handles: - $1, $2, etc. positional arguments (last one swallows remaining) - $ARGUMENTS placeholder (all args joined)
Supports syntax like ${2:foobar} where the default value is used
if the argument is missing, empty, or whitespace-only.
ariane-emory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #213
Type of change
What does this PR do?
Adds a new syntax for providing default values for the arguments of custom slash commands that is used if the argument returns an empty string. Defaults may be other simple arguments and are chainable.
Compatible with (but does not require) the
feat/argument-rangesbranch.Examples
${2:default}returns either the second actual argument or, if empty, a default string, "default".${3:$2:default}returns either the third argument or, if empty, the second argument, or if the second argument is also empty a default string, "default".