Added Dockerfile and added Docker build steps to Makefile#38
Open
trackibs wants to merge 1 commit intoarielf:masterfrom
Open
Added Dockerfile and added Docker build steps to Makefile#38trackibs wants to merge 1 commit intoarielf:masterfrom
trackibs wants to merge 1 commit intoarielf:masterfrom
Conversation
arielf
requested changes
Sep 14, 2018
Owner
arielf
left a comment
There was a problem hiding this comment.
Thanks for the PR. Appreciated.
Could you make the following changes?
- The docker build needs to be run as root or it'll fail. Can you may it so it gives guidance if you're not root
- On standard Ubuntu there's no need for /usr/local, and many systems may not even have
/usr/local, let alonebinunder it./usr/bin/python2exists by default so adding the/usr/local/bin/python2symbolic link is both unnecessary and likely to fail. - In the original
Makefilethe variableNAMEis already auto-discovered and set to whoever is running themakeso not sure about the comment about having data inroot.csv. This is not a PR change, just a comment about the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ariel,
I have created a Dockerfile which installs all the dependencies required to run this script and also updated the Makefile to add some make docker commands.
I renamed the file
ariel.csvtoroot.csvdue to it looking for the username :Then I run the following make command :
or the abbreviated command is :
It will then build the docker container if it doesn't exist and then generate the
scores.txtandroot.scores.pngfiles.I was hoping to be able to use your repository to help with doing similar machine-learning but with Irritable Bowel Syndrome (IBS) Symptoms.
Instead of adding in weight we instead add in a digestive symptom score which is calculated by an app called Cara :
There was a discussion earlier today on Reddit about using Machine Learning to troubleshoot IBS symptoms :
https://www.reddit.com/r/ibs/comments/9f1w46/im_working_on_a_startup_to_find_individual/
and it reminded me of your Weight Loss machine learning repository I looked at a while ago, any way let me know what you think!