Skip to content

.github/workflows: do not tag major version on gitlab#488

Merged
masseelch merged 1 commit intomasterfrom
j/no-major-version-gitlab
Mar 10, 2026
Merged

.github/workflows: do not tag major version on gitlab#488
masseelch merged 1 commit intomasterfrom
j/no-major-version-gitlab

Conversation

@masseelch
Copy link
Copy Markdown
Member

No description provided.

@masseelch masseelch requested review from giautm and noamcattan March 10, 2026 13:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis
Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

@github-actions
Copy link
Copy Markdown

Atlas detected changes to the desired schema

Migration Plan for atlas-actionView on Atlas Cloud

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found

📝 Steps to edit this migration plan

1. Run the following command to pull the generated plan to your local workstation:

atlas schema plan pull --url "atlas://atlas-action/plans/pr-488-R1cGcSfo" > pr-488-R1cGcSfo.plan.hcl

2. Open pr-488-R1cGcSfo in your editor and modify it as needed. Note that the result of the plan should align
the database with the desired state. Otherwise, Atlas will report a schema drift.

3. Push the updated plan to the registry using the following command:

atlas schema plan push --pending --file pr-488-R1cGcSfo.plan.hcl

4. Re-trigger the schema/plan action to update this comment:

gh run rerun 22905645074

@github-actions
Copy link
Copy Markdown

atlas schema lint on file://schema.lt.hcl

Status Rule Result
Naming violations detected Table "t1" violates the naming policy (NM102) schema.lt.hcl:1:1
Table "t2" violates the naming policy (NM102) schema.lt.hcl:1:1
Primary-key-required rule violated All tables must have a primary key
Table t1 must have a primary key schema.lt.hcl:3:1
Table t2 must have a primary key schema.lt.hcl:10:1
Primary-key-required rule violated All tables must have a primary key
Table t1 must have a primary key schema.lt.hcl:3:1
Table t2 must have a primary key schema.lt.hcl:10:1

@github-actions
Copy link
Copy Markdown

atlas schema lint on sqlite://schemarule.db

Status Rule Result
Naming violations detected Table "main.T1" violates the naming policy (NM102)
Primary-key-required rule violated All tables must have a primary key
Table T1 must have a primary key
Primary-key-required rule violated All tables must have a primary key
Table T1 must have a primary key

@masseelch masseelch requested review from a8m and luantranminh March 10, 2026 13:53
@masseelch masseelch merged commit 237b92e into master Mar 10, 2026
27 checks passed
@masseelch masseelch deleted the j/no-major-version-gitlab branch March 10, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants