feat: add per-resource prewarmDevDB override#347
Open
WoahitsJoe wants to merge 1 commit intoariga:masterfrom
Open
feat: add per-resource prewarmDevDB override#347WoahitsJoe wants to merge 1 commit intoariga:masterfrom
WoahitsJoe wants to merge 1 commit intoariga:masterfrom
Conversation
Member
277c6a2 to
2fe2980
Compare
Author
|
@giautm Should be good to go now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds a per-resource
spec.prewarmDevDBoverride for bothAtlasSchemaandAtlasMigration.Today
prewarmDevDBis only configurable at the operator level. In multi-tenant/platform setups this is too coarse, becausesome managed databases should keep the dev DB warm while others should scale it down after reconciliation.
Changes
spec.prewarmDevDBtoAtlasSchemaspec.prewarmDevDBtoAtlasMigrationprewarmDevDBdefaultWhy this approach
I initially considered namespace-level override, but per-resource control seemed like the better API because:
AtlasSchema/AtlasMigrationNotes
I was not able to run
go test/ codegen in my local environment for this PR because the Go toolchain was unavailable in that environment, so please let me know if you want me to adjust any generated files.