internal/controller: add cache directory creation in NewAtlasExec#352
Closed
chinhnguyenh wants to merge 1 commit intomasterfrom
Closed
internal/controller: add cache directory creation in NewAtlasExec#352chinhnguyenh wants to merge 1 commit intomasterfrom
chinhnguyenh wants to merge 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates NewAtlasExec to ensure Atlas CLI runs with a safer HOME default and proactively creates a cache directory in environments where the home directory is derived from DATA_DIR or needs to be overridden.
Changes:
- Add cache directory selection/creation logic in
NewAtlasExec. - Treat
HOME="/"the same as unset and default to/tmpfor safety. - Create
${HOME}/.cache(or/tmp/.cache) when using these fallback/home derivation paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.