chore: update dev container tools

[arii]

No description provided.

[arii]

🤖 AI Technical Audit

PR Review: Update Dev Container Tools (#9593)

Summary

This PR updates the .devcontainer configuration, introducing several new 'features' (Docker-in-Docker, GitHub CLI, JQ), modifying VS Code extensions, and injecting a local Vim configuration. While the intent is to improve developer experience, the PR introduces bloat, rigid personal preferences (Vim), and potential security risks via Docker-in-Docker.

Anti-AI-Slop

1. Over-Engineering: Inclusion of docker-in-docker in a TypeScript/Node.js environment is likely unnecessary unless explicitly required for integration testing. This adds significant overhead to container startup.
2. Overly Verbose Comments: The .vimrc generation in post-create.sh contains comments that state the obvious (e.g., set expandtab " Override: Use 4 spaces).
3. Bloat: The addition of GitHub.copilot and vscodevim.vim as recommended extensions forces personal tooling choices on all contributors.
4. Inconsistent Port Mapping: Port 9229 (Standard Node debug port) was removed and replaced with 8080 without explanation, which will break debugging workflows.
5. Stale/Missing Cleanup: The change from typescript-node:20-bullseye to typescript-node:20 is fine, but it leaves the exact OS version ambiguous (likely bookworm now).

---

File-by-File Analysis

.devcontainer/devcontainer.json

Problem: Port 9229 is essential for the V8 inspector (Node.js debugging). Removing it prevents remote debugging within the container. Additionally, the inclusion of docker-in-docker is a security risk and performance bottleneck if not actively used for building images inside the dev environment.

Implementation Sample:

// Revert the debug port and remove unnecessary overhead
"forwardPorts": [3000, 8080, 9229],
"features": {
  "ghcr.io/devcontainers/features/github-cli:1": {},
  "ghcr.io/devcontainers/features/jq:1": {}
  // Remove docker-in-docker unless justified
}

.devcontainer/post-create.sh

Problem: Injecting a .vimrc directly into the user's home directory inside the container is intrusive. It also uses a 4-space indentation which might conflict with the project's Prettier settings (usually 2 spaces for JS/TS projects).

Implementation Sample:

# Remove this block entirely. Users should manage their own 
# dotfiles via the devcontainer 'dotfiles' feature or personal sync.
# If required, ensure tabstop matches .editorconfig/prettierrc.

Architectural Impact

• Container Weight: The addition of multiple features and Docker-in-Docker increases the build time and resource consumption (RAM/CPU) for every developer starting the environment.
• Build Failures: The Build Check is currently failing. This is likely due to the change in the base image or the post-create.sh script execution order. Correlating this with the diff, the removal of specific Node debug ports or the addition of playwright deps on a generic node:20 image (which might lack specific system libs compared to the previous bullseye pin) is a primary suspect.

Review automatically published via RepoAuditor.