Conversation
Use SELECT FOR UPDATE on the annotation row to serialize concurrent requests, preventing two requests from both passing the max-1-note check and inserting duplicate notes on private annotations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for rsm-studio-site canceled.
|
✅ Deploy Preview for rsm-studio-frontend canceled.
|
… check scalar() returns Optional[int], causing mypy error when compared with >= 1. scalar_one() is safe here since COUNT() always returns exactly one row. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT FOR UPDATElock on the annotation row before checking the max-1-note limit for private annotations, preventing concurrent requests from both passing the check and inserting duplicate notesTest plan
test_private_annotation_single_note_limitpasses (sequential limit enforcement)test_private_annotation_note_limit_after_delete_and_recreatepasses (soft-delete aware)test_shared_annotation_multiple_notespasses (shared annotations unaffected)🤖 Generated with Claude Code