Conversation
Swatches now use role=radiogroup/radio with aria-checked, aria-label, roving tabindex, and arrow-key navigation for WCAG 4.1.2 compliance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for rsm-studio-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rsm-studio-site canceled.
|
Collaborator
Author
Needs human reviewWhat changed: ColorPicker now uses ARIA radiogroup semantics — swatches are Review checklist:
What to look for:
|
Collaborator
Author
|
All steps worked EXCEPT for 4-5. |
Arrow key handler updated activeColor but never called .focus() on the new element, so keyboard navigation appeared broken in the browser. Added focus management and a sequential navigation test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
Needs human reviewWhat changed: ColorPicker now uses ARIA radiogroup semantics — swatches are announced as radio buttons with checked state, and arrow key navigation replaces tab-between-buttons interaction. Review checklist:
What to look for:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="radiogroup"witharia-labelto the ColorPicker containerrole="radio",aria-checked,aria-label, and rovingtabindex<button>to<span>since thediv[role="radio"]handles all interactionfocus-visiblestyling from circle to swatch (the focusable element)Fixes WCAG 4.1.2 (Name, Role, Value) — screen readers now announce color swatches as a radio group with checked state.
Test plan
🤖 Generated with Claude Code