Skip to content

test: AnnotationMenu selection-to-menu pipeline tests#351

Merged
leotrs merged 1 commit intomainfrom
std-xrbh
Mar 27, 2026
Merged

test: AnnotationMenu selection-to-menu pipeline tests#351
leotrs merged 1 commit intomainfrom
std-xrbh

Conversation

@leotrs
Copy link
Copy Markdown
Collaborator

@leotrs leotrs commented Mar 27, 2026

Summary

  • Added 28 unit tests covering the core AnnotationMenu selection-to-menu pipeline that was previously untested
  • Tests cover: tryShowMenu, onCreateAnnotation (private/shared), onHighlight, buildAnchorData (yjs_relative vs plain), clearSelection, isRectInViewport, Escape key dismissal, outside-click dismissal, swatch color selection, and null-guard when annotationActions is absent
  • Mocks @floating-ui/vue to avoid infinite reactive loops in jsdom, and mocks anchor extraction utilities

Test plan

  • All 28 new tests pass locally
  • Existing AnnotationMenu tests (37 tests across 2 files) still pass
  • ESLint clean (no errors or warnings)
  • CI passes

🤖 Generated with Claude Code

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for rsm-studio-frontend ready!

Name Link
🔨 Latest commit 244d44d
🔍 Latest deploy log https://app.netlify.com/projects/rsm-studio-frontend/deploys/69c6b05ab15e660008b6aef4
😎 Deploy Preview https://deploy-preview-351--rsm-studio-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for rsm-studio-site canceled.

Name Link
🔨 Latest commit 244d44d
🔍 Latest deploy log https://app.netlify.com/projects/rsm-studio-site/deploys/69c6b05a7a382a0008fffb44

Cover tryShowMenu, onCreateAnnotation (private/shared), onHighlight,
buildAnchorData (yjs_relative vs plain), clearSelection, isRectInViewport,
keyboard (Escape) dismissal, outside-click dismissal, swatch color
selection, and null-annotationActions guard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@leotrs leotrs merged commit 2ad8a08 into main Mar 27, 2026
18 checks passed
@leotrs leotrs deleted the std-xrbh branch March 27, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant