Remove dead spill buffer path in generate_impl #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozirDmitriy
requested review from
Pratyush,
mmagician and
z-tech
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spill buffer allocation and buf declaration guarded by num_limbs > MAX_REGS were unreachable and never used. All public call sites hard-gate x86_64 ASM usage to limb counts 2..=6, and the proc-macros themselves emit an empty token stream for num_limbs > 6. Since the asm template does not reference {buf} and this branch cannot be reached, the code was dead and misleading, so it has been removed.