Refactor host import handling and update related tests#23
Merged
Conversation
- Introduced `env` module to encapsulate environment-related code generation. - Removed `needs_host` field from IR functions and signatures, simplifying function metadata. - Updated function signatures to use `Env` instead of `host`, reflecting the new environment structure. - Adjusted tests to accommodate changes in function signatures and environment handling. - Replaced `EnvImports` trait with `ModuleHostTrait` for better clarity and consistency in host implementations. - Modified memory and global handling in tests to align with the new environment structure. - Ensured all relevant tests pass with the updated code structure.
All exported module functions now take host as an explicit parameter. Update calls to sum_array, double_array, and memory_info to pass &mut host. Also update trait impl from EnvImports to ModuleHostTrait for consistency. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envmodule to encapsulate environment-related code generation.needs_hostfield from IR functions and signatures, simplifying function metadata.Envinstead ofhost, reflecting the new environment structure.EnvImportstrait withModuleHostTraitfor better clarity and consistency in host implementations.