Fix/async command dispatch #291
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Cannot execute
MyCommandscustom commands (even "registered") viaconsole-command-on-entryflag.Problem:
WorldGuard's
onCrossBoundaryevent often fires asynchronously. InvokingBukkit.dispatchCommanddirectly from this async context violates the Bukkit API contract, causing plugins that rely on the main thread (like MyCommand) to fail silently or throwIllegalStateException.Solution:
Implemented a hybrid execution strategy in
ConsoleCommandOnEntry/Exithandlers:Bukkit.isPrimaryThread(). If async, the command batch is scheduled viaBukkit.getScheduler().runTask(); otherwise, it runs immediately to minimize latency.try-catchblock so that a failure in one command (e.g., an unregistered command) does not halt the execution of subsequent commands.JavaPlugin.getProvidingPlugin(getClass())to ensure a valid plugin instance is used for scheduling.Tested on Paper 1.21.11 (
Paper version 1.21.11-88-main@8556cb4).Goal reached, works for me, will update this thread if I find any bugs/errors/etc.