Skip to content

Add early check for gh default repo in gh wrapper scripts #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arran4 merged 2 commits into from
Mar 7, 2026
Merged

Add early check for gh default repo in gh wrapper scripts #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
587f037
feat(gh): add early exit if gh default repo is not set
google-labs-jules[bot] Mar 6, 2026
bba3f04
feat(gh): add early exit if gh default repo is not set
google-labs-jules[bot] Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dot_local/bin/executable_gh-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ if ! command_exists git; then
exit 1
fi

if ! gh repo set-default --view > /dev/null 2>&1; then
Copy link
Owner

@arran4 arran4 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules does this only occur if it needs to be set?

Copy link
Contributor Author

@google-labs-jules google-labs-jules bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The gh repo set-default --view command only fails (returns a non-zero exit code) if a default repository hasn't been set yet. If one is already set, it successfully views it and returns 0, so the if block is skipped and the script continues.

echo "X No default remote repository has been set." >&2
echo "please run \`gh repo set-default\` to select a default remote repository." >&2
exit 1
fi

# Store original branch
original_branch=$(git branch --show-current)

Expand Down
6 changes: 6 additions & 0 deletions dot_local/bin/executable_gh-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
#!/bin/sh
set -eux

if ! gh repo set-default --view > /dev/null 2>&1; then
echo "X No default remote repository has been set." >&2
Copy link
Owner

@arran4 arran4 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules does this only occur if it needs to be set?

Copy link
Contributor Author

@google-labs-jules google-labs-jules bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The gh repo set-default --view command only fails (returns a non-zero exit code) if a default repository hasn't been set yet. If one is already set, it successfully views it and returns 0, so the if block is skipped and the script continues.

echo "please run \`gh repo set-default\` to select a default remote repository." >&2
exit 1
fi

prerelease_flag=""
git_tag_inc_args=""

Expand Down