Add support for application mime-type & remove redundant files#1
Closed
abarisic86 wants to merge 10 commits intoarribbar:multipleDataTypefrom
Closed
Add support for application mime-type & remove redundant files#1abarisic86 wants to merge 10 commits intoarribbar:multipleDataTypefrom
abarisic86 wants to merge 10 commits intoarribbar:multipleDataTypefrom
Conversation
… to see if it'll help with the current issue on iOS (SharedExtension.data() returns un undefined object).
… it fails if the url is constructed this way.
Enable opening external files with the application
Exit extension on close so that it can be called again
exit was causing the extension to close before the JavaScript code was executed, but only when the app was archived
Remove exit from iOS code
Owner
|
Sorry @abarisic86. Is it still up to date ? |
Author
|
It's used in production for our app.
…On Fri, Nov 9, 2018 at 10:54 AM Bart Arribe ***@***.***> wrote:
Sorry @abarisic86 <https://github.com/abarisic86>. Is it still up to date
?
I'll update my PR to be merged in alinz repo instead
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuGEwGcQRWPQbRmQXA1OJ3BBn3ZgJ8_ks5utVDAgaJpZM4TxPzZ>
.
|
Owner
|
Great. Can you just update the conflicted file ? |
Owner
|
And if you can update Readme file to know how to use your new functionality. It would be great. It seems there is a new contributor in alinz project, ready to help us and merge new PRs :) |
Author
|
@Taarna <https://github.com/Taarna> can you help with this?
…On Fri, Nov 9, 2018 at 11:13 AM Bart Arribe ***@***.***> wrote:
And if you can update Readme file to know how to use your new
functionality. It would be great. It seems there is a new contributor in
alinz project, ready to help us and merge new PRs :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuGE2kSjnmT_qjeul3JEe6-itv350XKks5utVVRgaJpZM4TxPzZ>
.
|
I'll take a look over the weekend |
Owner
|
If this PR alinz#84 is merged, it is better to create another PR to master project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.