Remove incorrect Ior contracts, and workaround KT-31886 #3841
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kover Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
||contracts don't result in smart casts. They really should, but in the meantime, doingblah !is SomeIorSubclassworks well, and is shorter!The removed contracts are clearly invalid. Consider when the relevant predicate(s) are
{ false }. The functions then returnfalse, but that tells us nothing about the type of the Ior.E.g.
isBoth({false}) {false}is alwaysfalse, no matter the Ior, so it doesn't mean that the Ior isn'tBoth.