Fix item count for socketed jewels#8
Open
pepijndevos wants to merge 1 commit intoartcom-net:masterfrom
Open
Conversation
The `continue` after handling a socketed jewel skips the `items_count -= 1` at the bottom of the loop, causing the parser to read past the end of the item list. This crashes when parsing characters with socketed jewels in mercenary (or other) items, as the next section header is misinterpreted as an item header. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continueafter handling a socketed jewel in_parse_itemsskips theitems_count -= 1at the bottom of the loop, causing the parser to over-read by one item per jewel0x6B66) is misinterpreted as an item headerReproduction
Any
.d2sfile where a mercenary item has a socketed jewel triggers:Fix
Add
items_count -= 1before thecontinueon line 106, matching the decrement at the bottom of the loop.🤖 Generated with Claude Code