Upgrade golangci-lint from v1.64.8 to v2.8.0#25
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades golangci-lint from v1.64.8 to v2.8.0 and applies formatting changes recommended by the new linter version. The upgrade includes configuration updates to support the v2 API format and import ordering standardization across Go files.
Changes:
- Upgrade golangci-lint version and migrate configuration to v2 format
- Reorder imports in Go files according to new linter standards (standard → external → local)
- Update error message formatting to remove trailing colon
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hack/make/dep_golangci_lint.mk | Updates golangci-lint version from 1.64.8 to 2.8.0 |
| .golangci.yml | Migrates configuration to v2 format with new structure for linters, formatters, and exclusions |
| Makefile | Updates lint target to use new v2 CLI flags |
| internal/workflow/preprocessing_test.go | Reorders imports to place local packages after external ones |
| internal/workflow/preprocessing.go | Reorders imports to place local packages after external ones |
| internal/eventlog/eventlog_test.go | Reorders imports to place local packages after external ones |
| internal/config/config_test.go | Reorders imports and updates test error messages to remove trailing colon |
| internal/config/config.go | Removes trailing colon from error message |
| cmd/worker/workercmd/cmd.go | Reorders imports to place local packages after external ones |
| cmd/worker/main.go | Reorders imports to place local packages after external ones |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2bad59d to
1f68c03
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 34.44% 34.44%
=======================================
Files 7 7
Lines 299 299
=======================================
Hits 103 103
Misses 194 194
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e125401 to
5954f10
Compare
| sections: | ||
| - standard | ||
| - default | ||
| - prefix(github.com/artefactual-sdps/preprocessing-base) |
There was a problem hiding this comment.
It looks like this was never added to the preprocessing-base references in https://github.com/artefactual-sdps/preprocessing-base?tab=readme-ov-file#create-a-new-repository.
Upgrade golangci-lint and apply changes recommended by linter.
5954f10 to
fa31ebc
Compare
Upgrade golangci-lint and apply changes recommended by linter.