Skip to content

Upgrade golangci-lint from v1.64.8 to v2.8.0#25

Merged
djjuhasz merged 1 commit intomainfrom
dev/upgrade-golangci-lint
Jan 19, 2026
Merged

Upgrade golangci-lint from v1.64.8 to v2.8.0#25
djjuhasz merged 1 commit intomainfrom
dev/upgrade-golangci-lint

Conversation

@djjuhasz
Copy link
Contributor

Upgrade golangci-lint and apply changes recommended by linter.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades golangci-lint from v1.64.8 to v2.8.0 and applies formatting changes recommended by the new linter version. The upgrade includes configuration updates to support the v2 API format and import ordering standardization across Go files.

Changes:

  • Upgrade golangci-lint version and migrate configuration to v2 format
  • Reorder imports in Go files according to new linter standards (standard → external → local)
  • Update error message formatting to remove trailing colon

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
hack/make/dep_golangci_lint.mk Updates golangci-lint version from 1.64.8 to 2.8.0
.golangci.yml Migrates configuration to v2 format with new structure for linters, formatters, and exclusions
Makefile Updates lint target to use new v2 CLI flags
internal/workflow/preprocessing_test.go Reorders imports to place local packages after external ones
internal/workflow/preprocessing.go Reorders imports to place local packages after external ones
internal/eventlog/eventlog_test.go Reorders imports to place local packages after external ones
internal/config/config_test.go Reorders imports and updates test error messages to remove trailing colon
internal/config/config.go Removes trailing colon from error message
cmd/worker/workercmd/cmd.go Reorders imports to place local packages after external ones
cmd/worker/main.go Reorders imports to place local packages after external ones

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djjuhasz djjuhasz force-pushed the dev/upgrade-golangci-lint branch 2 times, most recently from 2bad59d to 1f68c03 Compare January 16, 2026 19:16
@djjuhasz djjuhasz requested a review from jraddaoui January 16, 2026 19:16
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.44%. Comparing base (17c203e) to head (fa31ebc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   34.44%   34.44%           
=======================================
  Files           7        7           
  Lines         299      299           
=======================================
  Hits          103      103           
  Misses        194      194           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djjuhasz djjuhasz force-pushed the dev/upgrade-golangci-lint branch 2 times, most recently from e125401 to 5954f10 Compare January 16, 2026 22:07
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz!

sections:
- standard
- default
- prefix(github.com/artefactual-sdps/preprocessing-base)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was never added to the preprocessing-base references in https://github.com/artefactual-sdps/preprocessing-base?tab=readme-ov-file#create-a-new-repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Upgrade golangci-lint and apply changes recommended by linter.
@djjuhasz djjuhasz force-pushed the dev/upgrade-golangci-lint branch from 5954f10 to fa31ebc Compare January 19, 2026 16:37
@djjuhasz djjuhasz merged commit 3ce8088 into main Jan 19, 2026
7 checks passed
@djjuhasz djjuhasz deleted the dev/upgrade-golangci-lint branch January 19, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants