Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the pipeline by introducing more granular exit codes and descriptive error messages, replacing the previous behavior of exiting with code 20 for all failures. The version is also bumped to 1.9.0, and the primalbedtools dependency is updated.
Key changes:
- Enhanced error handling with specific exit codes and user-friendly messages for common failure scenarios
- Version bump to 1.9.0 with updated primalbedtools dependency to >=1.0.0
- Test updates to use artic-pan-dengue scheme instead of nCoV-2019
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bumped from 1.8.5 to 1.9.0 |
| environment.yml | Updated primalbedtools dependency from >=0.10.1 to >=1.0.0 |
| artic/utils.py | Changed read_file default parameter from False to empty string |
| artic/minion.py | Added comprehensive error handling with specific exit codes and messages, replaced os.system with subprocess.run |
| tests/get_scheme_unit_test.py | Updated test to use artic-pan-dengue scheme instead of nCoV-2019 |
| tests/minion_validator.py | Added scheme-length parameter to test command generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bede
approved these changes
Dec 18, 2025
bede
left a comment
There was a problem hiding this comment.
Looks great, and I've googled these error codes more times than I should admit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes [#174]
Quick PR which bumps version to 1.9.0 but mostly improves the pipelines error handling, no more will it exit 20 no matter what the problem is.....