-
Couldn't load subscription status.
- Fork 152
Add HorizontalPodAutoScaler Processor #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for adding test examples!
|
@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error |
It looks strange. I can see in PR diff also new service template and PDB. |
Yeah exactly that;s the reason why I ignored those changes and only committed mine. Think some devs are evening updating examples |
|
it can be related common prefix in resource name. can you try to rename it from |
sorry, i was speaking about your example, not pdb. existing examples should remain the same. in example diff we should see only hpa template and its value in values.yaml. |
|
@arttor Checks are all passing, can you review and merge this PR? |
sorry, we need to check why all existing templates were renamed. probably there is a bug in exiting code but i cannot merge this change. If we add only one hpa to test samples we should get only one template in result and no changes to other templates. |
Adding support for HorizontalPodAutoScaler from autoscaling/v1 primarily targeting minReplicas maxReplicas and targetCPUUtilizationPercentage