Skip to content

Conversation

@DheerajKN
Copy link

@DheerajKN DheerajKN commented Aug 6, 2025

Adding support for HorizontalPodAutoScaler from autoscaling/v1 primarily targeting minReplicas maxReplicas and targetCPUUtilizationPercentage

Copy link
Owner

@arttor arttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding test examples!

@DheerajKN
Copy link
Author

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

@arttor
Copy link
Owner

arttor commented Aug 7, 2025

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

It looks strange. I can see in PR diff also new service template and PDB.

@DheerajKN
Copy link
Author

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

It looks strange. I can see in PR diff also new service template and PDB.

Yeah exactly that;s the reason why I ignored those changes and only committed mine. Think some devs are evening updating examples

@arttor
Copy link
Owner

arttor commented Aug 7, 2025

it can be related common prefix in resource name. can you try to rename it from myapp-pdb to my-pdb or pdb

@arttor
Copy link
Owner

arttor commented Aug 7, 2025

it can be related common prefix in resource name. can you try to rename it from myapp-pdb to my-pdb or pdb

sorry, i was speaking about your example, not pdb. existing examples should remain the same. myapp-hpa -> my-hpa

in example diff we should see only hpa template and its value in values.yaml.

@DheerajKN DheerajKN requested a review from arttor August 7, 2025 20:53
@DheerajKN
Copy link
Author

@arttor Checks are all passing, can you review and merge this PR?

@arttor
Copy link
Owner

arttor commented Aug 8, 2025

@arttor Checks are all passing, can you review and merge this PR?

sorry, we need to check why all existing templates were renamed. probably there is a bug in exiting code but i cannot merge this change. If we add only one hpa to test samples we should get only one template in result and no changes to other templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants